Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto prior #603

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Remove auto prior #603

merged 2 commits into from
Dec 4, 2022

Conversation

tjburch
Copy link
Contributor

@tjburch tjburch commented Dec 3, 2022

Removes automatic_priors from bmb.Model. Adds the note that automatics are based on rstanarm to the docstring for priors. Closes #599.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #603 (c78f8d3) into main (fbd409c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files          38       38           
  Lines        3034     3029    -5     
=======================================
- Hits         2514     2510    -4     
+ Misses        520      519    -1     
Impacted Files Coverage Δ
bambi/models.py 85.67% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto
Copy link
Collaborator

Thanks a lot! :D

@tomicapretto tomicapretto merged commit 3b89e5e into bambinos:main Dec 4, 2022
@tjburch tjburch deleted the remove-auto-prior branch December 4, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the automatic_priors argument from bmb.Model()
3 participants