Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distributional models #607

Merged
merged 61 commits into from
Jan 6, 2023

Conversation

tomicapretto
Copy link
Collaborator

@tomicapretto tomicapretto commented Dec 5, 2022

Exciting changes are coming... TBD

Also closes #606, #449

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #607 (840172a) into main (347fd3f) will increase coverage by 4.00%.
The diff coverage is 85.50%.

❗ Current head 840172a differs from pull request most recent head 5345894. Consider uploading reports for the commit 5345894 to get more accurate results

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
+ Coverage   82.22%   86.22%   +4.00%     
==========================================
  Files          40       37       -3     
  Lines        3094     2236     -858     
==========================================
- Hits         2544     1928     -616     
+ Misses        550      308     -242     
Impacted Files Coverage Δ
bambi/data/datasets.py 96.15% <ø> (ø)
bambi/families/link.py 67.14% <50.00%> (+1.42%) ⬆️
bambi/terms/response.py 78.68% <50.00%> (+1.63%) ⬆️
bambi/terms/base.py 72.13% <60.00%> (-0.76%) ⬇️
bambi/utils.py 50.68% <62.50%> (+3.62%) ⬆️
bambi/terms/group_specific.py 94.44% <66.66%> (-0.96%) ⬇️
bambi/models.py 79.11% <71.97%> (-6.56%) ⬇️
bambi/families/univariate.py 82.73% <73.23%> (-3.43%) ⬇️
bambi/defaults/utils.py 80.64% <80.64%> (ø)
bambi/families/likelihood.py 85.36% <82.75%> (-8.52%) ⬇️
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto tomicapretto changed the title [WIP] Add distributional models Add distributional models Jan 5, 2023
@tomicapretto tomicapretto marked this pull request as ready for review January 5, 2023 16:05
@tomicapretto
Copy link
Collaborator Author

I don't expect to add any changes now. The example I wrote is not listed in the documentation because it's not polished. At this point, it's been so many many changes in this massive PR that I just want to merge and move on 😄

@aloctavodia
Copy link
Collaborator

There are so many changes here! I suggest trusting the tests and merging so you can enjoy a well-deserved weekend!

@tomicapretto tomicapretto merged commit d9df772 into bambinos:main Jan 6, 2023
@tomicapretto tomicapretto deleted the distributional_models branch January 6, 2023 18:45
@zwelitunyiswa
Copy link

Argentina wins the World Cup and my man @tomicapretto goes full code beast mode. I would have thought you still would be recovering from partying on the Avenida 9 de Julio!

@tomicapretto
Copy link
Collaborator Author

Argentina wins the World Cup and my man @tomicapretto goes full code beast mode. I would have thought you still would be recovering from partying on the Avenida 9 de Julio!

Haha, thanks! I don't live in Buenos Aires but celebrations here (Rosario) were incredible as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure in Sleepstudy example not being reproducible
4 participants