Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml #631

Merged
merged 13 commits into from
Feb 2, 2023
Merged

Use pyproject.toml #631

merged 13 commits into from
Feb 2, 2023

Conversation

tomicapretto
Copy link
Collaborator

Main changes

  • We put all the information in pyproject.toml. This means we removed
    • requirements.txt
    • requirements-dev.txt
    • requirements-optional.txt
    • MANIFEST.in
    • setup.cfg
    • setup.py
  • Make our workflows more robust, especially the release workflow.
    • Now we split the steps into build, test, and release. The first builds the source distribution. The second uploads it to TestPyPI, and the third finally uploads it to PyPI.
    • I added PYPI_TOKEN and TEST_PYPI_TOKEN secrets that are used in the workflow so we don't use personal usernames anymore.

@bambinos bambinos deleted a comment from review-notebook-app bot Jan 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Merging #631 (f585226) into main (07e6f77) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
+ Coverage   86.63%   86.66%   +0.03%     
==========================================
  Files          37       37              
  Lines        2199     2205       +6     
==========================================
+ Hits         1905     1911       +6     
  Misses        294      294              
Impacted Files Coverage Δ
bambi/version.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto
Copy link
Collaborator Author

I defer approval and merging to you just in case you spot something I'm missing @canyon289 @aloctavodia

CHANGELOG.md Outdated Show resolved Hide resolved
@canyon289
Copy link
Collaborator

LGTM. @aloctavodia deferring to you

Co-authored-by: Ravin Kumar <7213793+canyon289@users.noreply.github.com>
@tomicapretto tomicapretto merged commit c610691 into bambinos:main Feb 2, 2023
@tomicapretto tomicapretto deleted the to-pyproject branch February 2, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants