-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pyproject.toml #631
Merged
Merged
Use pyproject.toml #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #631 +/- ##
==========================================
+ Coverage 86.63% 86.66% +0.03%
==========================================
Files 37 37
Lines 2199 2205 +6
==========================================
+ Hits 1905 1911 +6
Misses 294 294
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I defer approval and merging to you just in case you spot something I'm missing @canyon289 @aloctavodia |
canyon289
reviewed
Jan 29, 2023
LGTM. @aloctavodia deferring to you |
Co-authored-by: Ravin Kumar <7213793+canyon289@users.noreply.github.com>
aloctavodia
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
pyproject.toml
. This means we removedrequirements.txt
requirements-dev.txt
requirements-optional.txt
MANIFEST.in
setup.cfg
setup.py
PYPI_TOKEN
andTEST_PYPI_TOKEN
secrets that are used in the workflow so we don't use personal usernames anymore.