Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inflated families #654

Merged
merged 10 commits into from
Mar 22, 2023
Merged

Conversation

tomicapretto
Copy link
Collaborator

@tomicapretto tomicapretto commented Mar 22, 2023

This PR adds inflated families to Bambi. The following list may be updated in the process

  • zero_inflated_poisson
  • zero_inflated_binomial
  • zero_inflated_negativebinomial

Edit

I also want to add

  • zero_inflated_beta
  • zero_one_inflated_beta

but they will come in a separate PR. These distributions don't exist in PyMC and I need to see if it's better to add them here or in PyMC directly.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Merging #654 (f972f8d) into main (afcabb6) will increase coverage by 0.04%.
The diff coverage is 95.00%.

❗ Current head f972f8d differs from pull request most recent head fd0005f. Consider uploading reports for the commit fd0005f to get more accurate results

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   87.56%   87.60%   +0.04%     
==========================================
  Files          40       40              
  Lines        2629     2647      +18     
==========================================
+ Hits         2302     2319      +17     
- Misses        327      328       +1     
Impacted Files Coverage Δ
bambi/defaults/distributions.py 100.00% <ø> (ø)
bambi/defaults/families.py 87.50% <ø> (ø)
bambi/defaults/utils.py 87.50% <ø> (ø)
bambi/families/likelihood.py 85.36% <ø> (ø)
bambi/families/univariate.py 90.22% <94.44%> (+0.66%) ⬆️
bambi/families/family.py 93.25% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto tomicapretto changed the title [WIP] Add inflated families Add inflated families Mar 22, 2023
@tomicapretto tomicapretto marked this pull request as ready for review March 22, 2023 18:09
@tomicapretto tomicapretto merged commit efa7800 into bambinos:main Mar 22, 2023
@tomicapretto tomicapretto deleted the zero_inflated branch March 22, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants