Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in FAQ #686

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Fix links in FAQ #686

merged 3 commits into from
Jun 23, 2023

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jun 22, 2023

Thank your for opening a PR!

Before you proceed, please check the following notes.

  • Make sure you describe the changes introduced in the PR.
  • If this PR addresses an existing issue, please mention it here.
  • Check our Guidelines for Contributing.
  • In particular, pay attention to the pull request checklist.
  • The most important points are to
    • Install all the needed requirements (requirements.txt, requirements-dev.txt, etc.)
    • Make sure all test pass.
    • Make sure your code passes black.
    • Make sure your code passes pylint.

@wd60622 wd60622 marked this pull request as ready for review June 22, 2023 05:42
@wd60622
Copy link
Contributor Author

wd60622 commented Jun 22, 2023

Goal of the PR is to fix the hyperlinks on the FAQ page.

Screenshot 2023-06-22 at 07 43 28

@wd60622
Copy link
Contributor Author

wd60622 commented Jun 22, 2023

@tomicapretto
Copy link
Collaborator

tomicapretto commented Jun 23, 2023

I think the failed test is because of something new in PyMC 5.5.

Btw, thanks a lot for the fix!

@tomicapretto tomicapretto merged commit 6d6872f into bambinos:main Jun 23, 2023
@wd60622 wd60622 deleted the fix_faq_links branch June 23, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants