-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Horseshoe Prior #836
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@julianlheureux thanks for the contribution! This is something we wanted for a long time. Before merging, it would be nice to add a test. I imagine the following would be OK as it covers the basic use cases:
In both tests I would check that
I would not check for the absence of divergences, etc. because we can't guarantee they won't happen. I know the PyMC part of the tests is not trivial as one has to interact with PyMC internals. So, if you want you can get started with the test and I can share a snippet showing how to test that. |
Thanks @julianlheureux! There's something happening with the tests, but that's unrelated to the code contribution. It has to be with data loading. |
Hello! In this pull request, I added the horseshoe prior to the dictionary where Bambi stores specific prior distributions.
This is Carvalho's horseshoe prior, designed for the coefficients of a multiple regression model with a large number of explanatory variables, where only a few are statistically significant.