Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use number of rows from out-of-sample data in multivariate families #847

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Use number of rows from out-of-sample data in multivariate families #847

merged 1 commit into from
Sep 26, 2024

Conversation

tomicapretto
Copy link
Collaborator

This PR closes #845

@tomicapretto tomicapretto mentioned this pull request Sep 22, 2024
Closed
@GStechschulte
Copy link
Collaborator

Do you want a review of this? :)

@tomicapretto
Copy link
Collaborator Author

Do you want a review of this? :)

Sure, it can't hurt :)

But I'm also waiting for a response here #845 (comment)

@sepro
Copy link

sepro commented Sep 25, 2024

Do you want a review of this? :)

Sure, it can't hurt :)

But I'm also waiting for a response here #845 (comment)

Currently trying to have a look, will let you know if this resolves the issue I had ! (Hopefully some time this week)

@tomicapretto
Copy link
Collaborator Author

Do you want a review of this? :)

Sure, it can't hurt :)
But I'm also waiting for a response here #845 (comment)

Currently trying to have a look, will let you know if this resolves the issue I had ! (Hopefully some time this week)

thanks!

@sepro
Copy link

sepro commented Sep 26, 2024

Have been able to install this branch and run my code and can confirm this now works with a different set of observations when predicting.

@tomicapretto
Copy link
Collaborator Author

@GStechschulte do you still want to review? We can merge it otherwise

GStechschulte
GStechschulte approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@GStechschulte GStechschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! :)

@GStechschulte GStechschulte merged commit 46d5572 into bambinos:main Sep 26, 2024
4 checks passed
@tomicapretto tomicapretto deleted the fix_predict_shape branch September 26, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GStechschulte GStechschulte GStechschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.predict() data, needs same number of samples as .fit() with kind="response"
3 participants
@tomicapretto @GStechschulte @sepro