linux.d/debian: use correct string match syntax #5103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test(1) command (also known as '[') does not use the '==' syntax for testing equality, which is a feature of bash's '[[' builtin. String equality is tested with '=', and numeric equality with '-eq'. This eliminates a series of warnings when running BuildLinux.sh on Debian-derived systems: [schwarzgerat](0) $ ./BuildLinux.sh -u ./linux.d/debian: line 39: [: ==: unary operator expected ./linux.d/debian: line 39: [: ==: unary operator expected ./linux.d/debian: line 42: [: ==: unary operator expected
|
Thank you for the suggestion. I need to conduct some tests. |
MackBambu
reviewed
Oct 30, 2024
There was a problem hiding this comment.
@lanewei120 "=" has better compatibility and can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test(1)command (also known as[(1)) does not use the==syntax for testing equality, which is a feature of bash's[[builtin. String equality is tested with '=', and numeric equality with-eq. This eliminates a series of warnings when runningBuildLinux.shon Debian-derived systems: