-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps/wxWidgets: Disable EGL for wxGLCanvas #923
Conversation
To work around <supermerill/SuperSlicer#1093>.
This PR fixes the graphical render issues on Ubuntu 22.04 LTS and I imagine other distros. Can this be approved? |
I think a potentially better change might be to update the bundled GLEW to support EGL. (This would also pipeclean support for Wayland.) For some reason, the GLEW that's packed in is truly ancient; if it were updated to support EGL, it would probably fix this the other way around. |
Nixpkgs carries the latest glew version (2.2.0) and the same issue exists there (*), so the underlying issue is elsewhere. (*) Previously we were disabling EGL in wxWidgets as a workaround, but then switched to Prusa's 3.1.4 fork which doesn't have EGL enabled by default |
I think that Bambu Slicer overrides GLEW to use the internal one no matter what, even if there is a system GLEW? So Nix carrying GLEW 2.2.0 I think shouldn't change anything. (Now, that said, I'm reading around the internet that GLEW for EGL is incomplete, which is giving me serious 'how does anything ever work?' vibes. Which features of GLEW does Slic3r/PS/SS/BS use? Hard to know until I try it, I guess!) Mostly I don't really want to paper over this because I am worried that the lack of Wayland support is causing me problems with the Gstreamer stuff I'm working on (#12), and disabling EGL would close the door on Wayland indefinitely, since Wayland doesn't have GLX. |
@jwise @zhaofengli I incorporated the change with a linux-only build option for the script for SoftFever's fork of this, I did incorporate those changes into my PR so it doesn't effect windows builds and doesn't require the library to change. At least atm. |
Yeah, I'm absolutely mired in the Gstreamer stuff and I have no idea if I'm going to ever emerge onto the EGL side of it. Building with this temporarily is probably a reasonable plan. |
I'm building this all in docker/github actions I just blow away the build environment so no biggie |
@zhaofengli I think #1053 has been merged into master. See if that works for you? If so, we can close this one. |
Sorry for the late response. I just tried it and it worked well! Thanks for the amazing work @jwise and I'll close this PR. |
* Adding the Qidi X-Plus Qidi X-Plus profile Qidi X-Plus image * Revision of the pressure plate model Qidi X-Plus * Add Artillery Profiles Artillery Genius Artillery Hornet
This works around supermerill/SuperSlicer#1093 which causes the build plate to not be visible in some setups.
It's the same workaround used by Nixpkgs for its PrusaSlicer and SuperSlicer packages until it switched to Prusa's wxWidgets 3.1.4.
Ref: #12