-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppImage builder feature #996
AppImage builder feature #996
Conversation
9698163
to
e2e9e9b
Compare
we have merged #1053 and it seems no need to disable egl for wxGLCanvas under Linux now could you remove this commit and submit again? |
@lanewei120 I'll rebase this without that commit. I do need to add a dependency for Arch Linux users, but they can just install WebKit2gtk and it resolves it. Adding this dependency is non-trivial, since I can't easily just assume it's dependencies would be satisfied enough. I think it's less grief at the moment to just let them install that as a external dependency. |
80287e3
to
b760cc6
Compare
It seems I'm getting build errors now that weren't happening previously I'm investigating now. @lanewei120 I'm not sure if you've noticed this error but it doesn't work: The Result is this I think the intent was I'm going to change it to this |
b760cc6
to
5899b8b
Compare
#1062 it seems this is the problem with compiles, if you need me to, I can remove that change. |
5899b8b
to
c6345f8
Compare
yes, this is a boost issue we submitted recently, and we will fix it soon |
@lanewei120 , To add I think it's worth just pulling @SoftFever's CICD (SoftFever/OrcaSlicer@96c861f) commits into this repo actually, I did look at cherry picking out those commits so we can at least get official builds generated on changes. Although it seems the build system has diverged quite a bit between that fork and the Official repository. The changes to the Mac OSX/Windows build process are pretty significant but that's probably out of scope for the PR. I suspect Bambu Labs is already doing this internally in some way but at least PRs can be quickly verified here. |
we have submitted the fix here: #1097 |
I will check that commit currently we have an similiar flow to check the building and basic issues internally thanks |
I'm going to redo this AppImage build as using the community script seems to miss dependencies from the system. This works to a degree but fails on newer distributions like Arch/Fedora. |
are you using the newest codes on branch v1.4.2? please use it which is a stable release of v1.4.2 |
@lanewei120 I'll give it a go, but I already have seen better results using linuxdeployqt instead of the BuildLinux.sh script. To add I don't think the idea was to build separate AppImages for each distribution family. It feels like a much more sane approach to dealing with the dependencies, as Sub Surface is using this approach to great success. for packaging AppImages. |
the first commit of boost is also no need now we have submited the fix 2 weeks ago here 698d51c sorry for the inconvenience |
@fang64
althrough linuxdeployqt maybe a better solution BTW: I have verified it a test-folk |
c6345f8
to
917b865
Compare
…en (bambulab#996) Fixed double-label for fan speed-up time, fixed label to include hyphen.
…en (bambulab#996) Fixed double-label for fan speed-up time, fixed label to include hyphen.
I have created a PR to create AppImages using GitHub Actions Workflow.
The main modification I made was add a flag to BuildLinux.sh so it'll skip the memory check as it's not a problem to compile with less ram. That ram check could be removed but I've just simply added a flag to skip it.
I also added a check to see if you are attempting to run the AppImage build in a docker container so it'll patch the appimagetool so it'll run and use the extract and run option in that scenario. GH Action workflow isn't in a container but when testing with nektos/act it was needed to confirm the build was working correctly.
I've incorporated @zhaofengli 's fix Disable EGL for wxGLCanvas with my PR to get the appimage to work properly.
The artifacts work nearly perfectly and the AppImage builds work great.