feat: add config-plugin for Expo #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo: Readme
hirbod
commented
Jun 15, 2022
| @@ -0,0 +1 @@ | |||
| // keep this empty file, otherwise expo-module-scripts will throw an error that "no inputs found" | |||
There was a problem hiding this comment.
I had to create this empty file or it would error out with "no inputs found".
|
@Almouro I've done the final remaining tasks. Also deleted the autogenerated README inside of flipper-native. expo-modules-script might re-create it again when you bundle the plugin, watch out :D |
Almouro
approved these changes
Jun 20, 2022
|
Beautiful, here we go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright @Almouro, here we go.
Fixes #40
The Plugin is ready. The Readme was auto generated, we need to discuss what to include (defining scope) and the naming to include this plugin has also changed.