-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: rotation on some android devices #398
Conversation
Hi @MrLibya do you a device example on which it does not work ? |
I think I finally understand the problem. I've detailed it in this issue #402. With your fix if the image has an exif orientation value = |
Sorry for not providing example code I was busy, I'll look into that and see what I can do |
@taboulot I've added handing for mirrored ( flipped ) image exif, I've used those images to test on https://github.com/recurser/exif-orientation-examples Code test: https://gist.github.com/MrLibya/cabea9cbbb776cc5e77bf1a56df2d8d2 |
i need this!! |
@taboulot anything else needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a new bullet point in section Limitation on the README to explain that EXIF orientation code is correctly handl on Android but not yet on iOS with a link to this issue: #402 ?
I left 2 comments. |
@taboulot Done ✅ |
Perfect 👌 I will release it in few minutes |
Error
On some android devices the photo is rotated
Solution
This caused by lack of some exif rotation is not read on creating the new bitmap for rotation.