Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lists): fix imperative focus not always working on virtualized lists #128

Merged
merged 1 commit into from
May 27, 2024
Merged

fix(lists): fix imperative focus not always working on virtualized lists #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/lib/src/spatial-navigation/SpatialNavigator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,13 @@ export default class SpatialNavigator {
*
* Still, I want to queue it, because the element might not be registered yet (example: in the case of virtualized lists)
*/
public queueFocus = (id: string) => {
if (this.focusQueue) return;
this.focusQueue = id;
public deferredFocus = (id: string) => {
setTimeout(() => {
if (this.lrud.getNode(id)) {
this.lrud.assignFocus(id);
return;
}
}, 0);
};

/**
Expand Down
2 changes: 1 addition & 1 deletion ...tial-navigation/components/virtualizedList/SpatialNavigationVirtualizedListWithScroll.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export const SpatialNavigationVirtualizedListWithScroll = typedMemo(
setCurrentlyFocusedItemIndex(index);
if (idRef.current) {
const newId = idRef.current.getNthVirtualNodeID(index);
spatialNavigator.queueFocus(newId);
spatialNavigator.deferredFocus(newId);
}
},
}),
Expand Down
Loading