Refactor(ItemWithIndex): remove ItemWithIndex type #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hVirtualParentContext
|
This is awesome, thank you so much ❤️ . I think there might be a bug though on the virtualized grid indices!
vs
|
|
@pierpo I fixed it and updated the video in the PR's description |
pierpo
pushed a commit
that referenced
this pull request
Jun 10, 2024
* feat(virtualizedList): pass index in props of itemContainerWithAnimatedStyle * feat(virtualizedListWithNodes): pass index in props of itemWrapperWithVirtualParentContext * feat(virtualizedListWithScroll): pass index as props of itemWrapperWithScrollContext * feat(virtualizedGrid): pass index in renderHeader, GridRow then ItemWrapper * refactor(virtualizedGrid): stop using ItemWithIndex type * refactor(virtualizedList): stop using ItemWithIndex type in layers of list * refactor(virtualizedList): delete ItemWithIndex type * refactor(SNvirtualizedList): stop indexing data in first layer * refactor(Lists): delete addIndex helper * fix(virtualizedGrid): fix index of row by taking header into account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An index was manually added to every iterable data passed to
VirtualizedLists.In
convertToGridfunction (dedicated toVirtualizedGrids), we saw that map gives access to theindexof every item of data.We can use the same for
VirtualizedListsby using the index passed inside therenderItemprop.The refactoring is cut in 2 parts :
Tests realized on Web :
web.mov
Some performance tests