bumped to v4 endpoints, removed feedback, and added /start return pos… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylejmorris
reviewed
Aug 10, 2022
| const callID = await startAPI(apiKey, modelKey, modelInputs) | ||
| export async function runMain(apiKey: string, modelKey: string, modelInputs: object = {}): Promise<any>{ | ||
| const startOut = await startAPI(apiKey, modelKey, modelInputs) | ||
| if (startOut["finished"] == true){ |
There was a problem hiding this comment.
Did you check what happens if "finished" doesn't exist? will this crash?
There was a problem hiding this comment.
i.e assuming runMain is called for older sdks too can this ever not return the key properly
There was a problem hiding this comment.
if /start doesn't return it for some reason, the SDK falls back on our /check endpoint which doesn't use this "finished" logic as a break condition.
kylejmorris
approved these changes
Aug 10, 2022
|
confirming this was deployed as 4.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We've depricated parts of the backend in an attempt to simplify it of backward compatibility, therefore we're making fresh endpoints on a new major version to make sure that pre-serverless users of our backend have a stable 3.x.x release now that we're on 4.x.x
The API itself is not changing, so no need for users to rewrite their code. We're just deprecating old parts of the backend.
Testing
Tested end-to-end with recently deployed v4 endpoints on backend, everything works as expected.