Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Setup integration tests #1323

Merged
merged 28 commits into from
Jul 3, 2024
Merged

[Test] Setup integration tests #1323

merged 28 commits into from
Jul 3, 2024

Conversation

tiagofilipenunes
Copy link
Collaborator

@tiagofilipenunes tiagofilipenunes commented Jul 1, 2024 •
edited
Loading

Simple POC to setup the integration library before starting to write integration tests.

Changes made:

  • Add jest-dom eslint plugin
  • Update testing-library packages
  • Update vitest and vite
  • Added examples of vitest.mock and vitest.hoisted - as mock calls are hoisted, you can use vitest.hoisted to run code before the mocks
  • vite-plugin-rewrite-all plugin was removed as part of updating vite as it is no longer used and has been deprecated
  • Added two customRenders - both with some providers added and one with the router added as well
  • Added wagmi wallet mock

Notes:

  • Currently tests are running with mode flag production because otherwise there's an error when loading the config. Alternatively, the config file can be mocked and this flag removed
  • Similar as above for the compiled abis - we currently compiled them before the tests and alternatively they can be mocked

@tiagofilipenunes
Add and update packages
5cb3a40 
- Update testing-library dom, jest-dom, react and user-event packages
- Add eslint jsdom plugin
- Update vitest
@tiagofilipenunes
Remove unnecessary plugin
62cb724
@tiagofilipenunes
Update vite and vite react plugin
1017363
@tiagofilipenunes
Update yarn.lock
03793a4
@tiagofilipenunes
Add jest-dom eslint plugin
d28f5ba
@tiagofilipenunes
Add jest-dom types to vite-env.d.ts
a6db9b3
@tiagofilipenunes
Use SVG plugin in vitest
b740f52
@tiagofilipenunes
Add setup script to vitest to add mocks
b7e2695
@tiagofilipenunes
Add custom testing-library renders
03dc017
@tiagofilipenunes
Add tsconfig types
818cc22
@tiagofilipenunes
Fix MarketPriceIndication test:
1cde6da 
- afterEach instead of beforeEach for clean-up
- No need to mock the Tooltip as the issue was with .svg files not being parsed correctly
- Replace toBeTruthy and toBeNull with toBeInTheDocument as per jsdom lint rules
@tiagofilipenunes
Fix useKeyPress test descriptors
e02e688
@tiagofilipenunes
Add component and page example tests
9f49067
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 1, 2024 •
edited
Loading

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: c2bb5fa
Status: ✅  Deploy successful!
Preview URL: https://cd242680.carbon-app-sei.pages.dev
Branch Preview URL: https://setup-integration-tests.carbon-app-sei.pages.dev

View logs

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 1, 2024 •
edited
Loading

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: c2bb5fa
Status: ✅  Deploy successful!
Preview URL: https://e56c4179.carbon-app-csq.pages.dev
Branch Preview URL: https://setup-integration-tests.carbon-app-csq.pages.dev

View logs

@tiagofilipenunes tiagofilipenunes marked this pull request as ready for review July 3, 2024 09:30
GrandSchtroumpf
GrandSchtroumpf reviewed Jul 3, 2024
View reviewed changes
src/components/common/WarningMessageWithIcon.test.tsx Outdated Show resolved Hide resolved
src/libs/testing-library/index.tsx Show resolved Hide resolved
src/libs/testing-library/setup.ts Outdated Show resolved Hide resolved
src/libs/testing-library/utils.ts Show resolved Hide resolved
vite.config.ts Show resolved Hide resolved
GrandSchtroumpf
GrandSchtroumpf approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@GrandSchtroumpf GrandSchtroumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !

@tiagofilipenunes tiagofilipenunes merged commit 2dfb637 into main Jul 3, 2024
2 checks passed
@tiagofilipenunes tiagofilipenunes deleted the setup-integration-tests branch July 3, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrandSchtroumpf GrandSchtroumpf GrandSchtroumpf approved these changes

@zavelevsky zavelevsky zavelevsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiagofilipenunes @zavelevsky @GrandSchtroumpf