-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
343 remove test stubs #344
Conversation
…and_submit_transaction`) into a separate function
…ructions` and `validate_and_submit_transaction`
…ests relying on this input parameter passed as `XS_ARBOPPS`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why keep AM_SINGLE
at all at this point? In bot.py I'd suggest removing the only usage as follows, and then delete the AM_SINGLE attribute definition at class level:
def _find_arbitrage(
self,
flashloan_tokens: List[str],
CCm: CPCContainer,
arb_mode: str = 'single',
randomizer=int
) -> dict:
random_mode = self.AO_CANDIDATES if randomizer else None
arb_finder = self._get_arb_finder(arb_mode)
finder = arb_finder(
flashloan_tokens=flashloan_tokens,
CCm=CCm,
mode="bothin",
result=random_mode,
ConfigObj=self.ConfigObj,
)
return {"finder": finder, "r": finder.find_arbitrage()}
Thanks, that was my thought as well, but I noticed that |
… removed in a separate PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - except there are some unresolved conflicts with current main. Can you please resolve the conflicts so that the PR has no conflicts with main... then I'll approve.
…into 343-remove-test-stubs
…b.com/bancorprotocol/fastlane-bot into 343-remove-test-stubs
…into 343-remove-test-stubs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced the pro's outweigh the con's with all these changes. Convince me otherwise - and also address the specific comments concerning rawTransaction
usage in multiple places.
Handles issue #343