Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and improve event-fetching #364

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Simplify and improve event-fetching #364

merged 5 commits into from
Feb 12, 2024

Conversation

barakman
Copy link
Collaborator

@barakman barakman commented Feb 8, 2024

  1. Simplify the code for fetching events.
  2. Avoid fetching duplicated events.

zavelevsky
zavelevsky previously approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@zavelevsky zavelevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please run and compare the results

Base automatically changed from base-update-static-data to develop February 9, 2024 18:54
@mikewcasale mikewcasale dismissed zavelevsky’s stale review February 9, 2024 18:54

The base branch was changed.

mikewcasale
mikewcasale suggested changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@mikewcasale mikewcasale left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the outputs for all of the removed functions could be tested against the new function(s), in order to ensure equivalent outputs. Please provide such tests or explain your reasoning for not providing them.

@barakman
Copy link
Collaborator Author

barakman commented Feb 12, 2024 •
edited
Loading

It seems like the outputs for all of the removed functions could be tested against the new function(s), in order to ensure equivalent outputs. Please provide such tests or explain your reasoning for not providing them.

I've done it locally.
Adding such test for it means preserving old code, which doesn't make much sense.

@barakman barakman merged commit 21f0f4f into develop Feb 12, 2024
3 checks passed
@barakman barakman deleted the simplify-and-improve-event-fetching branch February 12, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikewcasale mikewcasale mikewcasale approved these changes

@Lesigh-3100 Lesigh-3100 Awaiting requested review from Lesigh-3100

@zavelevsky zavelevsky Awaiting requested review from zavelevsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barakman @zavelevsky @mikewcasale