Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Fantom Support #378

Merged
merged 80 commits into from
Feb 21, 2024
Merged

Adds Fantom Support #378

merged 80 commits into from
Feb 21, 2024

Conversation

mikewcasale
Copy link
Contributor

Combines issues #362 and #360 plus various configurations required for support.

mikewcasale and others added 30 commits February 7, 2024 11:09
@mikewcasale
Adds support for custom flashloan fees
94c26e8
@mikewcasale
Adds custom RPC url support
d941c8b
@mikewcasale
simplifying changes
dff5b44
@mikewcasale
Delete constants.py
d25f94e
@mikewcasale
Update connect.py
016297c
@mikewcasale
Updating with actual fee
bdfa1f0
@mikewcasale
adds specific handling in the case where the custom rpc is for tender…
de21541 
…ly testing
@mikewcasale
simplified the approach
3ad9f16
@mikewcasale
Merge branch 'develop' into 346-add-handling-of-flashloan-fee-1
ae4c773
@mikewcasale
Changes fee approach, corrects typing and docstrings
99b0b5b
@mikewcasale
Merge branch 'develop' into 346-add-handling-of-flashloan-fee-1
73c7254
@mikewcasale
adding default fee to satisfy failing tests
37b79ca
@mikewcasale
Merge branch '346-add-handling-of-flashloan-fee-1' of https://github.…
5b44855 
…com/bancorprotocol/fastlane-bot into 346-add-handling-of-flashloan-fee-1
@mikewcasale
Merge branch 'develop' into 361-add-support-for-custom-rpc
b6c8283
@Lesigh-3100
Add Fantom
61bcf3b
@mikewcasale
Merge branch 'develop' into 346-add-handling-of-flashloan-fee-1
1be8460
@mikewcasale
Merge branch 'develop' into 361-add-support-for-custom-rpc
1d717b6
@Lesigh-3100
Create tokens.csv
b25c34c
@NIXBNT
add fantom
7e0976b
@NIXBNT
Update tokens.csv
50d9e70
@NIXBNT
add fantom
d018f8c
@NIXBNT
static_pool_data placeholders
64bdb50
@Lesigh-3100
Update solidly_v2.py
f70ea89
@mikewcasale
Merge branch '346-add-handling-of-flashloan-fee-1' into fantom-rpc-fl…
03b87d7 
…ashloan-configs
@mikewcasale
Merge remote-tracking branch 'origin/369-add-support-for-fantom-netwo…
287a64d 
…rk' into fantom-rpc-flashloan-configs
@Lesigh-3100
Update network.py
adfe570
@Lesigh-3100
Update constants.py
f63d8d8
@mikewcasale
Updating the correct fee
c8352e0
@mikewcasale
Update constants.py
f19a1ec
@NIXBNT
fix wei->float flashloan fee amt
b82fb74
barakman
barakman requested changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@barakman barakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File routehandler.py seems to contain a ton of changes, most if not all appear to be cosmetic.
Rather hard to follow each and every one of them, so please pay special attention to that.

.env.example Outdated Show resolved Hide resolved
fastlane_bot/helpers/routehandler.py Outdated Show resolved Hide resolved
fastlane_bot/helpers/routehandler.py Show resolved Hide resolved
fastlane_bot/helpers/routehandler.py Outdated Show resolved Hide resolved
fastlane_bot/helpers/routehandler.py Show resolved Hide resolved
run_blockchain_terraformer.py Outdated Show resolved Hide resolved
run_blockchain_terraformer.py Show resolved Hide resolved
mikewcasale and others added 17 commits February 15, 2024 08:17
@mikewcasale
Update main.py
5c36317
@mikewcasale
remove unused variable definition
47c7661
@mikewcasale
removed faulty assert statement
7935274
@mikewcasale
Update run_blockchain_terraformer.py
6464c6a
@mikewcasale
Merge branch 'fantom-rpc-flashloan-configs' into argparse-backward-co…
8cab5f9 
…mpatibility
@mikewcasale
Update NBTest_907_RuntimeParameters.py
c109b68
@mikewcasale
Merge branch 'argparse-backward-compatibility' of https://github.com/…
1b09f4d 
…bancorprotocol/fastlane-bot into argparse-backward-compatibility
@mikewcasale
Update NBTest_907_RuntimeParameters.py
3ba0b43
@mikewcasale
silence verbose logging
d3efda8
@mikewcasale
replaced lambda's with functions in args
85ce1fd
@mikewcasale
simplified condition
f4f3f6a
@mikewcasale
Merge pull request #380 from bancorprotocol/argparse-backward-compati…
c2aecda 
…bility

Update main.py
@Lesigh-3100
Update .env.example
b398f8e
@Lesigh-3100
Update README.md
a13b486
@Lesigh-3100
Update solidly handling in Terraformer
d029e59
@Lesigh-3100
Update solidly_v2.py
d7952c3
@Lesigh-3100
Update run_blockchain_terraformer.py
24e3908
barakman
barakman requested changes Feb 20, 2024
View reviewed changes
run_blockchain_terraformer.py Outdated Show resolved Hide resolved
@barakman barakman self-requested a review February 20, 2024 17:33
@mikewcasale mikewcasale merged commit 6f37f2a into develop Feb 21, 2024
3 checks passed
@mikewcasale mikewcasale deleted the fantom-rpc-flashloan-configs branch February 21, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barakman barakman barakman approved these changes

@Lesigh-3100 Lesigh-3100 Awaiting requested review from Lesigh-3100

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikewcasale @barakman @Lesigh-3100 @NIXBNT