Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Remove redundant loading component #2790

Merged
merged 10 commits into from
Dec 16, 2020

Conversation

Pitchanai
Copy link
Contributor

Fixed: #1556

Implementation details

  • Remove redundant loading component

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@render
Copy link

render bot commented Oct 21, 2020

Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflict.

scan/src/components/data-source/DataSourceExecute.re Outdated Show resolved Hide resolved
scan/src/components/Loading.re Outdated Show resolved Hide resolved
CHANGELOG_UNRELEASED.md Outdated Show resolved Hide resolved
@evilpeach evilpeach merged commit 8ef1b4e into master Dec 16, 2020
@evilpeach evilpeach deleted the remove-redundant-loading-component branch December 16, 2020 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant loading component
3 participants