Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Pyband & Bandchain.js: Added get request evm proof on pyband and bandchain.js #2972

Merged
merged 6 commits into from
Dec 9, 2020

Conversation

pzshine
Copy link
Member

@pzshine pzshine commented Dec 8, 2020

Fixed: #2961

Implementation details

  • Pyband
    • Added new get_request_evm_proof_by_request_id including test and new EVMProof dataclass
    • Raised Error when the account doesn't exist on with_auto
  • Bandchain.js
    • Added new getRequestEVMProofByRequestID including test and new EVMProof inteface

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@pzshine pzshine requested a review from evilpeach December 8, 2020 08:44
@render
Copy link

render bot commented Dec 8, 2020

helpers/bandchain2.js/src/data.ts Outdated Show resolved Hide resolved
@pzshine pzshine merged commit b362354 into master Dec 9, 2020
@pzshine pzshine deleted the pyband-get-proof branch December 9, 2020 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the proof functions on client module
2 participants