Remove functions specifically required for precompiled version #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following two can be removed as well, for the same reason. |
Member
Author
Removed in commit 920f797. |
txhsl
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed functions were specifically required for the precompile versions since they override functions that consider an immutable (set during deployment) variable of the logic contract. Because the deployment part is not executed for the precompile version, these needed to be overridden with specific data suited for the precompile.
Thus, now for a logic update, a new logic contract needs to be deployed. This means its deployment part will be executed and its immutable variable will be set, so that the original functions must be used.