antimev: modify priceHeap to prioritize encrypt wrapper tx #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
reviewed
Aug 2, 2024
|
|
||
| // IsEncWrapperTx Checks whether a transaction is a wrapper transaction of an encrypted transaction | ||
| func IsEncWrapperTx(tx *types.Transaction) bool { | ||
| // TODO: now we only check to address is reward contract, consider add gasPrice and data check in future |
Contributor
There was a problem hiding this comment.
For IsEnc it's likely sufficient, we shouldn't care much about data (unless there is some unencrypted part of it) and gasPrice should be checked elsewhere.
Contributor
There was a problem hiding this comment.
BTW, some fee check can be important to prevent DOSing the pool with minimally priced transactions (that can evict nonencrypted ones). But that's not for IsEnc as well, it's a policy in its essense.
Merged
Member
|
Not relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
priceHeapto prioritize encrypt wrapper tx.