dbft: add requestTxs for dbft #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This PR is valid for CNs requesting missing transactions from peers under high transactions load. 4cn_cn1.log
4cn_cn2.log
4cn_cn3.log
4cn_cn4.log
|
Collaborator
|
CN requested for missing txs, but got
Details
|
AnnaShaleva
reviewed
Jan 9, 2024
chenquanyu
added a commit
that referenced
this pull request
Jan 16, 2024
AnnaShaleva
reviewed
Jan 16, 2024
Member
There was a problem hiding this comment.
LGTM!
@chenquanyu, could you please squash the commits into a single commit (may be done with git rebase -i HEAD~2) and name this commit something like "dbft: implement WithRequestTx callback" and add Close #59. message to the commit body? Like described in https://github.com/nspcc-dev/.github/blob/master/git.md#commits.
Minor comments are left to be fixed, after that ready to be merged. We're going to include this PR into NeoX T2 version.
Member
@nicolegys, I think this is done because we request the same transactions from multiple different peers. First peer responds, the node saves transaction, then second peer responds and the node already have this transaction got from the first peer. We have #97 to improve this behaviour. |
chenquanyu
force-pushed
the
dbft-request-txs
branch
from
b506b8f to
4ebff76
Compare
AnnaShaleva
reviewed
Jan 16, 2024
chenquanyu
force-pushed
the
dbft-request-txs
branch
from
4ebff76 to
78d480e
Compare
chenquanyu
force-pushed
the
dbft-request-txs
branch
from
68085e0 to
7e713d2
Compare
AnnaShaleva
approved these changes
Jan 17, 2024
Member
AnnaShaleva
left a comment
AnnaShaleva
left a comment
There was a problem hiding this comment.
@nicolegys, @roman-khimov agree to merge?
roman-khimov
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #59 Integrate transaction request mechanism.