WP-Builder: Feat/introduce-navigator-layout #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangank36
commented
Jul 6, 2023
| */ | ||
| export const gutenbergNavigatorLayoutTester = rankWith( | ||
| 2, | ||
| uiTypeIs("NavigatorLayout") |
There was a problem hiding this comment.
Remember the layout name NavigatorLayour
| <p>Go to home</p> | ||
| </NavigatorButton> | ||
| <JsonFormsDispatch | ||
| uischema={navigatorLayout.elements[0].elements[index]} |
There was a problem hiding this comment.
Looped hole on business screen, addressed on incoming ObjectRenderer (hopefully!)
| <NavigatorProvider initialPath="/"> | ||
| <NavigatorScreen path="/"> | ||
| <p>This is the home screen.</p> | ||
| {navigatableProps.filter((({dotPath}) => dotPath.split(".").length < 2 )).map(({path, key, dotPath}, index) => ( |
There was a problem hiding this comment.
For starter, we only render the keys that are 1st level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressed the new layout renderer
NavigatorLayout, we had achieved some thing as followedgetObjectProperties, we can extract all the nested object properties into an array and use it to render ALLNavigatorScreenat first runbusinessscreen is a loop hole, because I am hard coded theelementsof the NavigatorLayout, we should filter the 1st level properties betterReference
#19