Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid indentation #240

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: invalid indentation #240

merged 1 commit into from
Sep 6, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Sep 6, 2024 •
edited
Loading

Overview

  • In the getting started guide, one code block was not indented properly and also it was using plain EOF in the heredoc which tried to substitute the env-var declared in the yaml, using "EOF" fixes this problem.

Fixes #239

@csatib02
fix: invalid indentation
3b2aea5 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02 csatib02 requested a review from a team as a code owner September 6, 2024 11:23
@csatib02 csatib02 self-assigned this Sep 6, 2024
@csatib02 csatib02 removed the request for review from a team September 6, 2024 11:23
@csatib02 csatib02 added the kind/bug Categorizes issue or PR as related to a bug. label Sep 6, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines label Sep 6, 2024
@csatib02 csatib02 mentioned this pull request Sep 6, 2024
Closed
@csatib02 csatib02 merged commit 58c854e into main Sep 6, 2024
9 checks passed
@csatib02 csatib02 deleted the fix/getting-started-invalid-indentation branch September 6, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgecse lgecse lgecse approved these changes

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

@ramizpolic ramizpolic Awaiting requested review from ramizpolic

@akijakya akijakya Awaiting requested review from akijakya

Assignees

@csatib02 csatib02

Labels
kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting started - test deployment won`t echo actual value of env variable
2 participants
@csatib02 @lgecse