Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/parent home #117

Merged
merged 7 commits into from
Aug 2, 2022
Merged

Feature/parent home #117

merged 7 commits into from
Aug 2, 2022

Conversation

sungwoo-shin
Copy link
Member

๐Ÿ“ PR Summary

image

์ฃผ์š” ์ž‘์—… ๋ทฐ๋ฅผ ์บก์ฒ˜ํ•ฉ๋‹ˆ๋‹ค.

๐ŸŒฒ Working Branch

feature/parent-home

๐ŸŒฒ TODOs

  • [์ค‘์š”] kids slice๋ฅผ family slice์™€ ๋‹ค์‹œ ๋ถ„๋ฆฌํ•˜์˜€์Šต๋‹ˆ๋‹ค. family slice์˜ ์ฝ”๋“œ๋ฅผ ์ตœ๋Œ€ํ•œ ๊ฑด๋“œ๋ฆฌ์ง€ ์•Š๋Š” ๋ฐฉํ–ฅ์œผ๋กœ ์ˆ˜์ •ํ•ด๋‘์—ˆ์œผ๋‹ˆ ํ™•์ธํ•ด๋ณด์‹œ๊ณ  family slice ๋‚ด๋ถ€ ์ฝ”๋“œ๋ฅผ ์ •๋ฆฌํ•ด์ฃผ์„ธ์š”.
  • suggested -> proposed ๋„ค์ด๋ฐ ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค.
  • /Walking -> /Detail ๋„ค์ด๋ฐ ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค. (๋ถ€๋ชจ์ธก์—์„œ๋Š” ๋ˆ๊ธธ ์ƒ์„ธ ๋ณด๊ธฐ ์‹œ ๊ธˆ์ฃผ์˜ ๋ˆ๊ธธ ๋ชฉ๋ก์—์„œ ์ด๋™ํ•ฉ๋‹ˆ๋‹ค.)
  • selectedKid, hasMultipleKids ์ „์—ญ์ƒํƒœ๋กœ ๊ด€๋ฆฌํ•˜๋„๋ก ๋ณ€๊ฒฝํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ๋‹ค์ž๋…€์˜ ๊ฒฝ์šฐ ์ž๋…€ ์„ ํƒ ์‹œ ์ถ”๊ฐ€๋กœ ๋ฐ์ดํ„ฐ๋ฅผ ๋ฐ˜์ž…ํ•ฉ๋‹ˆ๋‹ค. ์บ์‹œ ๋˜ํ•œ ๊ตฌํ˜„ํ•˜์˜€์Šต๋‹ˆ๋‹ค. ์ถ”ํ›„ ๋กœ์ง์„ ๋ฐœ์ „์‹œํ‚ค๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.
  • ์ œ์•ˆ๋ฐ›์€ ๋ˆ๊ธธ ์•„์ดํ…œ ํด๋ฆญ ์‹œ ๋ชจ๋‹ฌ ์ ์šฉ ์™„๋ฃŒ, ์ž„์‹œ ๋ฐ”ํ…€์‹œํŠธ ์‚ฌ์šฉํ•˜์˜€์Šต๋‹ˆ๋‹ค. ๋ฐ”ํ…€์‹œํŠธ ์ปจํ…์ธ  ์ถ”๊ฐ€์ž‘์—… ์™„๋ฃŒ ์‹œ ์ˆ˜์ •ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.
  • [์ž‘์—…์˜ˆ์ •] ์ œ์•ˆ๋ฐ›์€ ๋ˆ๊ธธ ๊ฑฐ์ ˆ ์‹œ ํ”ผ๋“œ๋ฐฑ ์ „์†ก
  • [์ž‘์—…์˜ˆ์ •] ๋ชจ๋ฐ”์ผ ๊ธฐ๊ธฐ QA ์ง„ํ–‰ํ•  ์ˆ˜ ์žˆ๋„๋ก ์ค€๋น„

Related Issues

#110

Comment on lines -88 to +89
export const selectKidsStatus = (state: RootState) => state.family.kidsStatus;
export const selectKids = (state: RootState) => state.family.kids;
// export const selectKidsStatus = (state: RootState) => state.family.kidsStatus;
// export const selectKids = (state: RootState) => state.family.kids;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

familySlice์—์„œ Kids๋ถ€๋ถ„ ์ œ๊ฑฐ๋Š” ์ œ๊ฐ€ ํ•˜๋ฉด ๋ ๊นŒ์š”??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ค ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹น

@9yujin 9yujin merged commit aeb0a44 into dev Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants