Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/api #162

Merged
merged 28 commits into from
Aug 19, 2022
Merged

Refactor/api #162

merged 28 commits into from
Aug 19, 2022

Commits on Aug 15, 2022

  1. fix: ESLint eqeqeq rule ์ ์šฉ

    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    983e8c2 View commit details
    Browse the repository at this point in the history

  2. refactor: SuggetBadeg -> ProposalBadge ๋„ค์ด๋ฐ ๋ณ€๊ฒฝ

    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    b4ca245 View commit details
    Browse the repository at this point in the history

  3. fix: == -> ===

    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    0a67fb7 View commit details
    Browse the repository at this point in the history

  4. feat: disable shouldCloseOnOverlayClick

    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    9770d78 View commit details
    Browse the repository at this point in the history

  5. refactor: anti pattern ๊ฐœ์„  

    - ๋ธ”๋ก ์Šค์ฝ”ํ”„์—์„œ๋Š” ํ•จ์ˆ˜ ์„ ์–ธ์‹์„ ์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š”๋‹ค.
- ํ•จ์ˆ˜ ๋‚ด์—์„œ ๋ฐ˜ํ™˜์€ ํ•œ ๋ฒˆ๋งŒ ํ•œ๋‹ค.
    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    d018376 View commit details
    Browse the repository at this point in the history

  6. feat: HomeTemplate mount ์‹œ animation ์‚ญ์ œ

    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    16beccb View commit details
    Browse the repository at this point in the history

  7. refactor: /utils/get ๊ฐœ์„  

    - anti pattern ํ•ด์†Œ
- moment.js -> day.js
    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    e39079e View commit details
    Browse the repository at this point in the history

  8. refactor: ํ•˜๋‚˜์˜ ํ•จ์ˆ˜์—์„œ๋Š” ํ•˜๋‚˜์˜ return๋งŒ ํ•˜๋„๋ก ๊ฐœ์„ 

    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    0f941f4 View commit details
    Browse the repository at this point in the history

  9. chore: ๋ณต์žกํ•œ ์ปดํฌ๋„ŒํŠธ์— ๋Œ€ํ•ด ์ฃผ์„ ์ž‘์„ฑ

    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    f276c7a View commit details
    Browse the repository at this point in the history

  10. pref: ์˜จ๋ณด๋”ฉ input ์ž…๋ ฅ ์‹œ useCallback ์ ์šฉ

    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    c12a1b9 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'dev' into refactor/norm

    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    69af645 View commit details
    Browse the repository at this point in the history

  12. fix: == -> ===

    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    8e8acbd View commit details
    Browse the repository at this point in the history

  13. refactor: CSS ์ฝ”๋“œ ๊ฐ„์†Œํ™”

    @sungwoo-shin
    sungwoo-shin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    3af96a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. chore: ํ•จ์ˆ˜๋ช… ๋ณ€๊ฒฝ

    @sungwoo-shin
    sungwoo-shin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    5e0f82b View commit details
    Browse the repository at this point in the history

  2. Revert "pref: ์˜จ๋ณด๋”ฉ input ์ž…๋ ฅ ์‹œ useCallback ์ ์šฉ" 

    This reverts commit c12a1b9.
    @sungwoo-shin
    sungwoo-shin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    d06987b View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. ๊ทœ์ง„ ์ฝ”๋“œ์—์„œ ๊ฐœ์„ ํ•  ์ˆ˜ ์žˆ๋Š” ๋ถ€๋ถ„ ๋งˆํ‚น

    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    358caab View commit details
    Browse the repository at this point in the history

  2. refactor: ๋ˆ๊ธธ ๋ฆฌ์ŠคํŠธ ์ฟผ๋ฆฌํŒŒ๋žŒ pending ์œ ์ง€, accept -> walking

    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    640b8d9 View commit details
    Browse the repository at this point in the history

  3. fix: conflict

    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    10a0689 View commit details
    Browse the repository at this point in the history

  4. refactor: challengeStatus ENUM ์ ์šฉ

    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    9c04180 View commit details
    Browse the repository at this point in the history

  5. refactor: level: 0 -> level: -4

    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    aa239f6 View commit details
    Browse the repository at this point in the history

  6. refactor: Modals ์ฝ”๋“œ ๊ฐ€๋…์„ฑ ๊ฐœ์„ 

    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    5dbe880 View commit details
    Browse the repository at this point in the history

  7. refactor: HomeTemplate ๊ฐ€๋…์„ฑ ๊ฐœ์„ 

    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    cda4551 View commit details
    Browse the repository at this point in the history

  8. refactor: refineBirthday ์žฌ์‚ฌ์šฉ์„ฑ ๊ฐœ์„ 

    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    17d99c2 View commit details
    Browse the repository at this point in the history

  9. refactor: convertTimeStampToYYYYMMDD ์žฌ์‚ฌ์šฉ์„ฑ ๊ฐœ์„ 

    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    1125302 View commit details
    Browse the repository at this point in the history

  10. refactor: isSelectedKid ์กฐ๊ฑด ์œ ์ง€๋ณด์ˆ˜์„ฑ ๊ฐœ์„ , map method ์‚ฌ์šฉ ์‹œ key ์ตœ์ƒ๋‹จ ์œ„์น˜

    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    f819350 View commit details
    Browse the repository at this point in the history

  11. refactor: RegisterBirthday boolean ๋ณ€์ˆ˜๋ช… ๊ฐœ์„ , ๋ถˆํ•„์š”ํ•œ logical test ์‚ญ์ œ

    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    741aa62 View commit details
    Browse the repository at this point in the history

  12. fix: fix: HomeTemplate mount ์‹œ transition background-color๋งŒ์œผ๋กœ ์ œํ•œ 

    - ๋ฐฐ๊ฒฝ ์•„๋ž˜๋กœ ๊น”๋ฆฌ๋Š” animation ์ ์šฉ ์‹œ CSS ์ž‘์—…์— ์‹œ๊ฐ„์„ ๊ณผ๋„ํ•˜๊ฒŒ ์‚ฌ์šฉํ• ๊ฒƒ ๊ฐ™์•„
- color์—๋งŒ transition์„ ์ ์šฉํ•ฉ๋‹ˆ๋‹ค.
- ๋ถ€๋ชจ์™€ ์ž๋…€๊ฐ€ ๋™์ผํ•œ transition์„ ๊ฒฝํ—˜ํ•ฉ๋‹ˆ๋‹ค.
    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    267915b View commit details
    Browse the repository at this point in the history

  13. chore: ์—๋Ÿฌ์ฒ˜๋ฆฌ ๋ง‰ํž˜ 

    - thunk์—์„œ error ๋ฐœ์ƒ ์‹œ rejected case ์ด๋™ ์‹œ action.payload undefined ์ƒํƒœ์ž„
- rejectWithValue ์‚ฌ์šฉํ•ด์„œ error๋ฅผ ์ „์—ญ์ƒํƒœ๋กœ ์ถ”๊ฐ€๋กœ ๊ด€๋ฆฌํ•ด์•ผํ•จ
- React Query migration ์‹œ ์—๋Ÿฌ์ฒ˜๋ฆฌ ๋กœ์ง ์ถ”๊ฐ€ํ•˜๊ณ , ์•ŒํŒŒ๋ฒ„์ „ ๋ฆด๋ฆฌ์ฆˆ ์‹œ์—๋Š” ์—๋Ÿฌ์ฒ˜๋ฆฌ ์—†์ด ๊ฐ€๋Š”๊ฒŒ ๋‚˜์„๊ฒƒ ๊ฐ™์Œ
    @sungwoo-shin
    sungwoo-shin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    7c2b415 View commit details
    Browse the repository at this point in the history