Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/axios private #237

Merged
merged 5 commits into from
Sep 13, 2022
Merged

Refactor/axios private #237

merged 5 commits into from
Sep 13, 2022

Conversation

sungwoo-shin
Copy link
Member

๐Ÿ“ PR Summary

  • axiosPrivate ๊ด€๋ จ ๋กœ์ง ๋ฆฌํŒฉํ† ๋ง
  • axiosPrivate ๋Œ€์‹  axiosPrivateTemp ์‚ฌ์šฉํ•ด์ฃผ์„ธ์š”. response.data.data๊ฐ€ ์•„๋‹Œ reponse.data๋กœ api response data ์ฒ˜๋ฆฌํ•˜์‹œ๋ฉด ๋ฉ๋‹ˆ๋‹ค.
  • ์—๋Ÿฌ ํ•ธ๋“ค ๋กœ์ง์€ ์ถ”ํ›„์— ์ž‘์„ฑํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

๐ŸŒฒ Working Branch

refactor/axiosPrivate

๐ŸŒฒ TODOs

Related Issues

resolves #223

- aT๋Š” ๋กœ์ปฌ ์Šคํ† ๋ฆฌ์ง€๋กœ ๊ด€๋ฆฌ, ๊ทธ์™ธ์˜ auth ๊ด€๋ จ ์ •๋ณด๋Š” authSlice ๋‚ด๋ถ€ auth ๊ฐ์ฒด์—์„œ ํ†ตํ•ฉํ•˜์—ฌ ๊ด€๋ฆฌ
- axiosPrivate ์š”์ฒญ ์‹œ useAxiosPrivate ํ›…์— ์˜ํ•ด ๋ฐ˜ํ™˜๋œ ์ธ์Šคํ„ด์Šค๋ฅผ ์‚ฌ์šฉํ•˜๋Š”๊ฒƒ์ด ์•„๋‹Œ axios.ts์—์„œ axiosPrivate ์ธ์Šคํ„ด์Šค๋ฅผ ์ฆ‰๊ฐ importํ•˜์—ฌ ์‚ฌ์šฉ
@9yujin 9yujin merged commit 0689e92 into dev Sep 13, 2022
@sungwoo-shin sungwoo-shin deleted the refactor/axiosPrivate branch September 18, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] v1.0.0 ๋ฆด๋ฆฌ์ฆˆ๋ฅผ ์œ„ํ•œ ์ตœ์ข… ์ž‘์—…
2 participants