Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/challenge create #51

Merged
merged 6 commits into from
Jul 11, 2022
Merged

Feature/challenge create #51

merged 6 commits into from
Jul 11, 2022

Conversation

9yujin
Copy link
Member

@9yujin 9yujin commented Jul 11, 2022

๐Ÿ“ PR Summary

๋ˆ๊ธธ๊ณ„์•ฝํ•˜๊ธฐ ์ž‘์—…์ค‘

๐ŸŒฒ Working Branch

feature/challenge-create

๐ŸŒฒ TODOs

  • ์ปฌ๋Ÿฌ, ํƒ€์ดํฌ ์ˆ˜์ •ํ•˜๊ธฐ
  • ์—์…‹ ๋””๋ ‰ํ† ๋ฆฌ ์ •๋ฆฌ

Related Issues

issue : #50

Copy link
Member

@sungwoo-shin sungwoo-shin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ์ปจ๋ฒค์…˜์ด ๋งž์ง€ ์•Š๋Š” ๋ถ€๋ถ„์ด ์žˆ์–ด์„œ ์ฝ”๋ฉ˜ํŠธ ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • redux store์— reducer ๋“ฑ๋กํ•˜๋Š” ์ฝ”๋“œ ํ™•์ธํ•„์š”ํ•œ ๋ถ€๋ถ„์ด ์žˆ์–ด์„œ ์ฝ”๋ฉ˜ํŠธ ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ™•์ธํ•˜๊ณ  ์ˆ˜์ • ํ•„์š”ํ•œ ์ฝ”๋“œ๋Š” ์ˆ˜์ • ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

import c2 from '../../../../assets/icons/itemName/c2.svg';
import c3 from '../../../../assets/icons/itemName/c3.svg';

const itemNameList = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฐฑ์—”๋“œ ๋ช…์„ธ์— ๊ณ„์•ฝ ์ƒํ’ˆ์œผ๋กœ ์จ์žˆ๋Š” ์ด๋ฆ„์ด itemName์ด์–ด์„œ, itemNames๋กœ ์ˆ˜์ •ํ•˜๊ฒ ์Šด๋‹ค


// configureStore๋Š” ๋ฆฌ๋•์Šค ์ฝ”์–ด ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์˜ ํ‘œ์ค€ ํ•จ์ˆ˜์ธ createStore๋ฅผ ์ถ”์ƒํ™”ํ•œ ๊ฒƒ์ด๋‹ค.
export const store = configureStore({
reducer: {
auth: authReducer,
challengePayload: challengePayloadSlice,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reducer๋ฅผ import ํ•ด์•ผํ•˜๋Š”๊ฑฐ ์•„๋‹Œ๊ฐ€์šฉ?

export const selectChallengePayload = (state: RootState) =>
state.challengePayload;

export default challengePayloadSlice.reducer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑธ์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋””ํดํŠธ ์ต์ŠคํฌํŠธ๋ผ ์ด๋ฆ„์ด ๋ฐ”๋€Œ๋Š”๊ฑฐ์ง€ ์ƒ๊ด€์€ ์—†๊ธดํ•˜๋„ค์šฉ... ์ˆ˜์ •ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!! ๊ทผ๋ฐ ์™œ ๋””๋ฒ„๊ฑฐ์—๋งŒ ๋œจ๊ณ  ๋ฐ๋ธŒํˆด์ฆˆ์—” ์•ˆ๋œจ๋Š”๊ฑฐ์ง€

@9yujin 9yujin merged commit 98aedd3 into dev Jul 11, 2022
@9yujin 9yujin deleted the feature/challenge-create branch July 11, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants