Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/design system #58

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Refactor/design system #58

merged 2 commits into from
Jul 12, 2022

Conversation

sungwoo-shin
Copy link
Member

πŸ“ PR Summary

ν™•μ •λœ λ””μžμΈ μ‹œμŠ€ν…œμ— λŒ€μ‘ν•˜μ—¬ λ¦¬νŒ©ν† λ§ ν•©λ‹ˆλ‹€. μƒˆλ‘œ μ‚°μ •ν•œ μ»΄ν¬λ„ŒνŠΈ κΈ°μ€€μœΌλ‘œ μ½”λ“œ μˆ˜μ •ν•©λ‹ˆλ‹€.

🌲 Working Branch

refactor/designSystem

🌲 TODOs

  • palette: μƒˆλ‘œ μ‚°μ •λœ μ»΄ν¬λ„ŒνŠΈμ— λŒ€ν•΄μ„œλ§Œ 색상 λŒ€μ‘°ν•˜μ—¬ ν™•μΈν•΄μ„œ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€. 기쑴에 λ§Œλ“€μ—ˆλ˜ μ»΄ν¬λ„ŒνŠΈμ€‘ μ΄λ²ˆμ— λ””μžμΈ ν™•μ •λ˜μ§€ μ•ŠλŠ” μ»΄ν¬λ„ŒνŠΈλŠ” error만 λœ¨μ§€ μ•Šκ²Œ ν•˜κ³  생상 ν™•μΈν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€. μΆ”ν›„ λ‹€μ‹œ μž‘μ—…ν•˜κ²Œ 되면 λͺ¨λ“  색상 확인 ν•„μš”ν•©λ‹ˆλ‹€.
  • radius: small, medium, large둜 μ„€μ •, μŠ¬λž™ ν†΅ν•΄μ„œ λ””μžμΈνŒ€μ— color처럼 주석 처리 λΆ€νƒν–ˆμŠ΅λ‹ˆλ‹€.
  • clacRem: λͺ¨λ“  typo code에 px λŒ€μ‹  rem 적용

Related Issues

resolves #57

@sungwoo-shin sungwoo-shin merged commit af71e74 into dev Jul 12, 2022
@sungwoo-shin sungwoo-shin deleted the refactor/designSystem branch July 12, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] ν™•μ •λœ λ””μžμΈ μ‹œμŠ€ν…œ 적용
1 participant