Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/home #97

Merged
merged 16 commits into from
Jul 28, 2022
Merged

Feature/home #97

merged 16 commits into from
Jul 28, 2022

Conversation

sungwoo-shin
Copy link
Member

@sungwoo-shin sungwoo-shin commented Jul 27, 2022 •
edited
Loading

πŸ“ PR Summary

  • μ΅œλŒ€ν•œ dev λΈŒλžœμΉ˜μ— λ³‘ν•©ν•˜μ§€ μ•Šκ³  μž‘μ—…ν•˜λ € ν–ˆμœΌλ‚˜ JWT 운용 ν…ŒμŠ€νŠΈλ₯Ό μœ„ν•΄ λ³‘ν•©ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • μ΅œλŒ€ν•œ dev λΈŒλžœμΉ˜μ— λ³‘ν•©ν•˜μ§€ μ•Šκ³  μž‘μ—…ν•˜λ € ν–ˆμœΌλ‚˜ κΈ°μ‘΄ μž‘μ—…μ€‘μ΄λ˜ 돈길 상세보기 νŽ˜μ΄μ§€ μž‘μ—…μ„ μ΄μ–΄μ„œ ν•˜κΈ° μœ„ν•΄ λ³‘ν•©ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • ν™ˆνŽ˜μ΄μ§€ κ΅¬ν˜„ μ™„λ£Œ, 돈길 상세보기 νŽ˜μ΄μ§€ 80% 정도 κ΅¬ν˜„ μ™„λ£Œν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • 돈길 상세보기 νŽ˜μ΄μ§€ μž‘μ—… 쀑 κΈ°νšλ‹¨μ—μ„œ λ„˜κ²¨ 받은 더미데이터 μ μš©μ„ μœ„ν•΄ μ„œλ²„λ‹¨ μˆ˜μ •μ΄ μžˆμ—ˆμŠ΅λ‹ˆλ‹€. 직후 ν™ˆ νŽ˜μ΄μ§€μ—μ„œ μ‚¬μš©ν•˜λŠ” API에 였λ₯˜κ°€ λ°œμƒν•˜μ—¬ 돈길 상세보기 νŽ˜μ΄μ§€ μž‘μ—…μ„ μ€‘λ‹¨ν•˜μ˜€μŠ΅λ‹ˆλ‹€. ν•΄λ‹Ή μž‘μ—…μ„ 마무리 ν•˜μ§€ λͺ»ν•˜μ˜€μ§€λ§Œ 변경내역이 λ§ŽκΈ°μ— 일단 PR μš”μ²­ν•΄λ‘κ² μŠ΅λ‹ˆλ‹€. λ³΅κ·€ν•˜κ²Œ 되면 νŽΈν•œ μ‹œκ°„μ— 리뷰 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€.
  • νœ΄κ°€κ°„ 변경내역이 많고, μž‘μ—…μ€‘μ΄λ˜ feature/challenge-step4λŠ” 이미 dev λΈŒλžœμΉ˜μ— λ³‘ν•©λ˜μ—ˆκΈ° λ•Œλ¬Έμ— λ°˜λ“œμ‹œ μƒˆ μž‘μ—…μ„ μœ„ν•΄μ„œλŠ” dev λΈŒλžœμΉ˜μ—μ„œ μƒˆλ‘œ λΆ„κΈ°ν•˜μ—¬ μ§„ν–‰ν•΄μ£Όμ„Έμš”.
  • μŠ¬λž™ ν”„λ‘ νŠΈ 채널에 μ „λ‹¬ν•˜κ³  싢은 λ‚΄μš©μ„ λͺ‡κ°€μ§€ μž‘μ„±ν•΄λ‘μ—ˆμŠ΅λ‹ˆλ‹€. νŠΉνžˆλ‚˜ 디렉토리 ꡬ쑰에 κ΄€λ ¨λœ μŠ€λ ˆλ“œλŠ” λ°˜λ“œμ‹œ ν™•μΈν•˜κ³  μ˜κ²¬μ„ λ‚¨κ²¨μ£Όμ„Έμš”.

🌲 Working Branch

🌲 TODOs

  • JWT 운용 κ΄€λ ¨ 둜직 ν…ŒμŠ€νŠΈ
  • ν™ˆ νŽ˜μ΄μ§€ ν•΄λ‹Ή μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„, μŠ€ν† λ¦¬ μ œμž‘, API 연동
  • 돈길 상세 보기 νŽ˜μ΄μ§€ κ΅¬ν˜„ (도쀑 μ„œλ²„ 였λ₯˜λ‘œ 쀑단)

Related Issues

#96

@sungwoo-shin
feat: home μ»΄ν¬λ„ŒνŠΈ 링크
7a14e2c
@sungwoo-shin
refactor: Home routing
f3b64c2
@sungwoo-shin
feat: pendingMoneyRoad 상세보기 별도 νŽ˜μ΄μ§€λ‘œ κ΅¬ν˜„
eddb161
@sungwoo-shin
feat: pendingMoneyRoad 상세보기 λͺ¨λ‹¬ κ΅¬ν˜„, z-index 문제 λ°œμƒ
d2e4db0
@sungwoo-shin
fix: z-index
cd37151
@sungwoo-shin
feat: ν™ˆ νŽ˜μ΄μ§€ μ»΄ν¬λ„ŒνŠΈ μŠ€ν† λ¦¬ μ œμž‘
95a90c1
@sungwoo-shin
style: 생년월일 μž…λ ₯ input 숫자 ν‚€νŒ¨λ“œ μ‚¬μš©ν•  수 μžˆλ„λ‘ pattern μΆ”κ°€
0ed4edb
@sungwoo-shin
feat: 생년월일 μž…λ ₯ νŽ˜μ΄μ§€ λ‹€μŒ λ²„νŠΌ μΆ”κ°€
fb43598
@sungwoo-shin
refactor: 초기 마운트 μ‹œμ—λ§Œ hydrate λ˜λ„λ‘ λ³€κ²½
78b84b9
@sungwoo-shin
refactor: util ν•¨μˆ˜ export 정리
75a2d21
@sungwoo-shin
refactor: assets 디렉토리λͺ… μ»¨λ²€μ…˜μ— λ§žμΆ”μ–΄ 정리
a969e0f
@sungwoo-shin
refactor: hooks, lib, store 정리
d881373
@sungwoo-shin
refactor: pages 디렉토리 정리
6c3b9ab
@sungwoo-shin
refactor: components 디렉토리 정리
03bf05b
@sungwoo-shin
μ„œλ²„ 였λ₯˜λ‘œ 인해 개발 쀑단
fa8e638
@sungwoo-shin
refactor: 디렉토리 ꡬ쑰 정리
b2ab4df
9yujin
9yujin approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@9yujin 9yujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

속이 λ‹€ μ‹œμ›ν•©λ‹ˆλ‹€ ν˜•λ‹˜

@sungwoo-shin sungwoo-shin merged commit ee788d2 into dev Jul 28, 2022
@sungwoo-shin sungwoo-shin deleted the feature/home branch July 28, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9yujin 9yujin 9yujin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sungwoo-shin @9yujin