This repository was archived by the owner on Jan 30, 2025. It is now read-only.
Fp 141 - filename variable optional #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbrimeyer
reviewed
Oct 3, 2022
variables.tf
Outdated
|
|
||
| variable "filename" { | ||
| description = "The path to the function's deployment package within the local filesystem." | ||
| default = "" |
There was a problem hiding this comment.
possible to leave this null and check that it's passed at all instead of misusing a zero val?
Author
There was a problem hiding this comment.
will this look like filename = var.filename != null ? var.filename : "" ?
I'm getting an error when trying to run the examples:
Error: Unsupported argument
│
│ on ../../main.tf line 4, in module "lambda":
│ 4: filename = var.filename != null ? var.filename : ""
│
│ An argument named "filename" is not expected here.
There was a problem hiding this comment.
Ah so the underlying module shtuff can't handle nulls, gotcha
There was a problem hiding this comment.
just make sure the zero value is documented that an empty string is basically psuedo-null to fulfill the interface
lbrimeyer
previously approved these changes
Oct 6, 2022
Author
|
@lbrimeyer Can I get this stamped again? |
lbrimeyer
approved these changes
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the filename to optional. Deleted the stub .zip files from the examples. All examples successfully execute a
terraform plan