This repository was archived by the owner on Jan 30, 2025. It is now read-only.
Refactor lambda and events #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Removed references to SNS. Replaced modules for CW, DDB, S3 with RV Standard module sources
…antiation. remove github links. change trigger module source to bankrate registry
rv-jgentile
reviewed
Mar 31, 2022
rv-jgentile
reviewed
Mar 31, 2022
rv-jgentile
reviewed
Mar 31, 2022
lbrimeyer
reviewed
Mar 31, 2022
lbrimeyer
reviewed
Mar 31, 2022
lbrimeyer
reviewed
Mar 31, 2022
lbrimeyer
reviewed
Mar 31, 2022
lbrimeyer
reviewed
Mar 31, 2022
main.tf
Outdated
Comment on lines
17
to
20
| project = var.project_name | ||
| service = var.service | ||
| owner = var.owner # || vertical | ||
| team_name = var.team_name |
There was a problem hiding this comment.
These can be provided by the tag object (since these are probably used to assign tag values).
lbrimeyer
reviewed
Mar 31, 2022
main.tf
Outdated
Comment on lines
83
to
90
| module "event-cloudwatch-scheduled-event" { | ||
| source = "./modules/event/cloudwatch-scheduled-event" | ||
| enable = lookup(var.event, "type", "") == "cloudwatch-scheduled-event" ? true : false | ||
| architecture = {} | ||
| lambda_function_arn = module.lambda.arn | ||
| schedule_expression = lookup(var.event, "schedule_expression", "") | ||
| } |
There was a problem hiding this comment.
Once we have feature/arg parity we can remove these dead config blocks.
lbrimeyer
reviewed
Mar 31, 2022
lbrimeyer
reviewed
Mar 31, 2022
lbrimeyer
reviewed
Mar 31, 2022
…le logic in arch struct for eadch trigger. Cleaned up unused code
rv-jgentile
reviewed
Apr 8, 2022
lbrimeyer
suggested changes
Apr 8, 2022
rv-jgentile
approved these changes
May 6, 2022
lbrimeyer
approved these changes
May 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening up PR to merge changes into master. These changes are made in order to bring this fork up to RV Standard level of completeness.