Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react/function-component-definition #42

Merged
merged 1 commit into from
May 9, 2022
Merged

Add react/function-component-definition #42

merged 1 commit into from
May 9, 2022

Conversation

doong-jo
Copy link
Contributor

@doong-jo doong-jo self-assigned this Apr 20, 2022
doong-jo
doong-jo commented Apr 20, 2022
View reviewed changes
web/.eslintrc.js
@@ -23,7 +23,7 @@ module.exports = {
"plugin:@typescript-eslint/recommended",
"plugin:import/typescript",
],
plugins: ["react", "jsx-a11y", "import", "prettier", "@typescript-eslint", "simple-import-sort",],
plugins: ["react", "jsx-a11y", "import", "prettier", "@typescript-eslint", "simple-import-sort"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요한 comma 제거

doong-jo
doong-jo commented Apr 20, 2022
View reviewed changes
web/.eslintrc.js
@@ -83,7 +84,7 @@ module.exports = {
"import/prefer-default-export": "off",
// 테스트 코드에 있는 dependencies를 dev로 옮기라고 경고 뜨는 이슈를 해결하기 위함
// https://github.com/banksalad/styleguide/pull/35#discussion_r603753937
"import/no-extraneous-dependencies": ["error", {"devDependencies": ["/**/*.ts?(x)"]}],
"import/no-extraneous-dependencies": ["error", { "devDependencies": ["/**/*.ts?(x)"] }],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier

doong-jo
doong-jo commented Apr 20, 2022
View reviewed changes
web/package.json
@@ -17,7 +17,7 @@
"eslint-plugin-import": "2.22.1",
"eslint-plugin-jsx-a11y": "6.4.1",
"eslint-plugin-prettier": "3.3.1",
"eslint-plugin-react": "7.23.1",
"eslint-plugin-react": "7.29.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsx-eslint/eslint-plugin-react#3248

관련 rule에 대한 개선사항이 해당 버전에 fix 되었음

grap3fruit
grap3fruit approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@grap3fruit grap3fruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
ask; 7.23.1 -> 7.29.4 간의 변경사항을 팔로업할 필요는 없을까요?

@doong-jo
Copy link
Contributor Author

doong-jo commented May 9, 2022

LGTM! ask; 7.23.1 -> 7.29.4 간의 변경사항을 팔로업할 필요는 없을까요?

당장 다 팔로업하기 보다는 함께 공통 eslint를 쓰게 되는 시점(monorepo)에 자연스레 챙겨지길 기대합니다!

@doong-jo doong-jo merged commit dad00cc into master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-iknow p-iknow p-iknow approved these changes

@winterjung winterjung winterjung approved these changes

@grap3fruit grap3fruit grap3fruit approved these changes

@rainist-web rainist-web Awaiting requested review from rainist-web

Assignees

@doong-jo doong-jo

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doong-jo @grap3fruit @winterjung @p-iknow