Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return type for getVersions endpoint #264

Merged
merged 1 commit into from
Aug 28, 2019
Merged

fix return type for getVersions endpoint #264

merged 1 commit into from
Aug 28, 2019

Conversation

sancyx
Copy link
Member

@sancyx sancyx commented Aug 28, 2019 •
edited
Loading

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License Apache 2.0

What's in this PR?

Return type of getVerions endpoint was wrongly annotated,, thus the generated OpenAPI spec is not correct.

Checklist

  • Error handling code meets the guideline
  • Logging code meets the guideline (TODO)

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

lpuskas
lpuskas approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@lpuskas lpuskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sancyx sancyx merged commit 14bd129 into master Aug 28, 2019
@sancyx sancyx deleted the versions_fix branch August 28, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpuskas lpuskas lpuskas approved these changes

@waynz0r waynz0r Awaiting requested review from waynz0r

@stoader stoader Awaiting requested review from stoader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sancyx @CLAassistant @lpuskas