Fix renameTo renaming React component prop name unexpectedly

See: facebook#219
baopham · Aug 20, 2017 · 794b2cd · 794b2cd
1 parent 2bed715
commit 794b2cd
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/collections/VariableDeclarator.js b/src/collections/VariableDeclarator.js
@@ -115,6 +115,15 @@ const transformMethods = {
             return false;
           }
 
+          if (
+            types.JSXAttribute.check(parent) &&
+            parent.name === path.node &&
+            !parent.computed
+          ) {
+            // <Foo oldName={oldName} />
+            return false;
+          }
+
           return true;
         })
         .forEach(function(path) {

diff --git a/src/collections/__tests__/VariableDeclarator-test.js b/src/collections/__tests__/VariableDeclarator-test.js
@@ -53,6 +53,7 @@ describe('VariableDeclarators', function() {
       '    blah() {}',
       '  }',
       '}',
+      '<Component foo={foo} />',
     ].join('\n'), {parser: babel}).program];
   });
 
@@ -127,6 +128,17 @@ describe('VariableDeclarators', function() {
 
       expect(identifiers.length).toBe(1);
     });
+
+    it('does not rename React component prop name', function () {
+      const declarators = Collection.fromNodes(nodes)
+        .findVariableDeclarators('foo')
+        .renameTo('xyz');
+
+      const identifiers = Collection.fromNodes(nodes)
+        .find(types.JSXIdentifier, { name: 'foo' });
+
+      expect(identifiers.length).toBe(1);
+    });
   });
 
 });