-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to run with Laravel 5.8 #194
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ | |
*/ | ||
class DynamoDbClientServiceTest extends TestCase | ||
{ | ||
public function setUp() | ||
public function setUp(): void | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are the type returns necessary? Would it be possible to remove these and drop the explicit php 7.1.3 requirement in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They are required by PHPUnit 8 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For development, I'm ok with the requirement of php7.1 and above. |
||
{ | ||
parent::setUp(); | ||
|
||
|
@@ -75,7 +75,7 @@ public function testUnsetDynamoDbClientService() | |
/** | ||
* Make sure we are not leaving any values set on the DynamoDbModel | ||
*/ | ||
public function tearDown() | ||
public function tearDown(): void | ||
{ | ||
parent::tearDown(); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did travis drop support for 5.6 and 7.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, Laravel 5.8 did. PHP 5.6 and PHP 7.0 is EOL and doesn’t receive any updates anymore.
The new void return declarations with Laravel 5.8 will only work with PHP 7.1 and above.