Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 10.x Compatibility #266

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 10.x.

Before merging, you need to:

  • Checkout the l10-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-dynamodb.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "baopham/dynamodb": "dev-l10-compatibility",
    }
}

Finally, run: composer update

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@nelson6e65 nelson6e65 added the missing tests Feature or bug that needs failing tests to replicate it label Feb 24, 2023
@atymic
Copy link

atymic commented Apr 11, 2023

@baopham any chance of a merge?

@nelson6e65
Copy link
Collaborator

nelson6e65 commented Apr 12, 2023

There are no automatic tests yet, @atymic. Sorry, I was busy, u.u. I'll check my test suite improvements this weekend to accelerate any new implementation.

But, I'm about to test it manually in a project. You can give it a try temporally by following the bot example.

@nelson6e65
Copy link
Collaborator

nelson6e65 commented Apr 12, 2023

@atymic let me see if I can make a pre-release. I'll check this later when I get home. But, would be great if you can give me any feedback if you can test the bot branch. :)

@nelson6e65 nelson6e65 self-assigned this Apr 18, 2023
@nelson6e65 nelson6e65 changed the base branch from master to php/81 April 18, 2023 04:35
@nelson6e65 nelson6e65 merged commit bd3298b into baopham:php/81 Apr 18, 2023
@nelson6e65
Copy link
Collaborator

@atymic Can you install and check if any problem in new v6.3.0 release?

@atymic
Copy link

atymic commented Apr 18, 2023

Installed, will give it a test later :)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing tests Feature or bug that needs failing tests to replicate it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants