Use tzdb with std feature
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadow-rs uses `std::error::Error`s, which are only implemented by tz-rs, and tzdb if their features `std` are enabled. Right now this is not a problem, because even if you are using tzdb without default features, tzdb still uses tz-rs with default-features. This is because tz-rs did not yet have the feature gate when tzdb v0.3 was released. Once tzdb v0.4 is released, the unconditional use of tzdb's std feature will be fixed, which would break this project. So this PR is proactively fixing the issue.
|
@Kijewski Thx again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shadow-rs uses
std::error::Errors, which are only implemented bytz-rs, and tzdb if their features
stdare enabled. Right now this isnot a problem, because even if you are using tzdb without default
features, tzdb still uses tz-rs with default-features. This is because
tz-rs did not yet have the feature gate when tzdb v0.3 was released.
Once tzdb v0.4 is released, the unconditional use of tzdb's std feature
will be fixed, which would break this project. So this PR is proactively
fixing the issue.