Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdl: small improvements #2285

Merged
merged 2 commits into from
Nov 1, 2022
Merged

sdl: small improvements #2285

merged 2 commits into from
Nov 1, 2022

Conversation

sreimers
Copy link
Member

@sreimers sreimers added this to the v2.10.0 milestone Oct 26, 2022
@sreimers sreimers changed the title sdl: add SDL_Init and SDL_VideoQuit sdl: small improvements Oct 26, 2022
alfredh
alfredh reviewed Oct 29, 2022
View reviewed changes
@alfredh
Copy link
Collaborator

alfredh commented Oct 29, 2022

I think we can get some inspiration from the FFmpeg code:

https://github.com/FFmpeg/FFmpeg/blob/master/libavdevice/sdl2.c

@sreimers sreimers marked this pull request as draft October 29, 2022 09:58
@sreimers sreimers marked this pull request as ready for review October 31, 2022 15:06
@alfredh alfredh merged commit 6246334 into main Nov 1, 2022
@alfredh alfredh deleted the sdl_init branch November 1, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfredh alfredh alfredh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sreimers @alfredh