-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ua: use sdp connection data instead origin #2298
Conversation
I wonder if sdp origin address is reliable at all? |
it is probably better to use the SDP Connection field instead. A valid SDP must have one or more connection fields, either one in the session level, |
2c32dfe
to
5e6445e
Compare
5e6445e
to
a9343e7
Compare
@cspiel1 can you check if sdp connection-address works for you? it looks like its used only for preferred address family detection and should more reliable than origin. WebRTC based clients use always |
Okay, I will test it. I also think that this is an improvement. |
I tested with:
Result:
Everything works correclty. |
Thanks |
WebRTC based clients use always
IP4 127.0.0.1
orIP4 0.0.0.0
as origin<addrtype> <unicast-address>
for privacy reasons.https://www.rfc-editor.org/rfc/rfc4566.html#section-5.2