call: logic fix in call_modify. remove call->sent_answer = false #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cHuberCoffee
commented
Jul 26, 2023
cHuberCoffee
commented
- call_modify triggers an SIP UPDATE or Re-Invite. Therefore it is an SDP offer. A reset of call->sent_answer is wrong.
cHuberCoffee
force-pushed
the
sdp_sent_answer_fix
branch
from
6a3ed2d to
d12e6b4
Compare
|
@sreimers : Please could you help with the mingw test? |
|
Is fixed in main now, rebase should work. |
* call_modify triggers an SIP UPDATE or Re-Invite. Therefore it is an SDP offer. A reset of call->sent_answer is wrong.
cHuberCoffee
force-pushed
the
sdp_sent_answer_fix
branch
from
d12e6b4 to
2b484f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.