ua: enforce magic cookie in Via branch #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreimers
reviewed
Apr 19, 2024
sreimers
reviewed
Apr 19, 2024
According to RFC 3261 section 8.1.1.7 the branch parameter in the Via header MUST start with the magic cookie "z9hG4bK". This is now enforced. Some UAs don't comply with this and send multiple requests with the same branch values which can cause issues.
maximilianfridrich
force-pushed
the
enforce_magic_via
branch
from
7a0d901 to
b541891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 3261 section 8.1.1.7 the branch parameter in the Via header MUST start with the magic cookie "z9hG4bK". This is now enforced.
Some UAs don't comply with this and send multiple requests with the same branch values which can cause issues.