rtp: lock more fields from rtcp_sess #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspiel1
force-pushed
the
rtp_lock_rtp_sess
branch
from
6bca09c
to
e315ad9
Compare
cspiel1
force-pushed
the
rtp_lock_rtp_sess
branch
from
c8bfa9d
to
c2e4edd
Compare
|
Need to rename the PR to match the name of baresip/baresip#2828. It should use the |
|
this looks good.. okay to merge .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to lock more fields of
rtcp_sess.This was found because of
commit 22bb762de43a895c57984f20dc1771f7529150ee Author: Christian Spielberger <c.spielberger@commend.com> Date: Wed Jan 3 14:53:23 2024 +0100 test: call - concurrency test for audio_debug()This PR removes the shortly added lock for
rtcp_source. Instead the lock ofrtcp_sessis used over larger code parts.The concurrency test in baresip was intensified in order to find concurrency problems and possible deadlocks with a higher chance.
commit e267bb2d1655d2b93cbfce21648de47847bf7912 (HEAD -> rx_thread_activate, origin/rx_thread_activate) Author: Christian Spielberger <c.spielberger@commend.com> Date: Thu Jan 4 14:09:34 2024 +0100 test: call - intensify RTCP/audio_debug concurrency test