Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic: Add support for gcc __sync intrinsics #467

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

Lastique
Copy link
Contributor

@Lastique Lastique commented Aug 4, 2022

This adds support for older gcc versions that didn't support __atomic intrinsics.

Related to #446 (comment)

CC @cspiel1

@Lastique Lastique force-pushed the feature/atomic_sync_intrinsics branch from d13417e to c495f41 Compare August 4, 2022 12:55
@cspiel1
Copy link
Collaborator

cspiel1 commented Aug 5, 2022

Thanks! I will try this with our blackfin build system.

@cspiel1
Copy link
Collaborator

cspiel1 commented Aug 5, 2022

src/main/main.c: In function 're_main':
src/main/main.c:1070: error: expected ')' before ';' token
src/main/main.c:1094: error: expected ')' before ';' token

Something wrong here with this line:

	if (re_atomic_rlx(&re->polling)) {

include/re_atomic.h Outdated Show resolved Hide resolved
This adds support for older gcc versions that didn't support
__atomic intrinsics.
@Lastique Lastique force-pushed the feature/atomic_sync_intrinsics branch from c495f41 to b6f8746 Compare August 5, 2022 10:34
@cspiel1
Copy link
Collaborator

cspiel1 commented Aug 5, 2022

Looks good now. It builds. Thanks!

@sreimers sreimers merged commit 8a4dac8 into baresip:main Aug 5, 2022
@Lastique Lastique deleted the feature/atomic_sync_intrinsics branch August 5, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants