send DTMF via hidden call #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspiel1
force-pushed
the
call_hidden_flag
branch
from
a9c95ea
to
d3ac0d2
Compare
alfredh
reviewed
Sep 20, 2022
src/telev/telev.c
Outdated
| @@ -341,6 +341,12 @@ int telev_poll(struct telev *tel, bool *marker, struct mbuf *mb) | |||
| } | |||
|
|
|||
|
|
|||
| bool telev_is_empty(struct telev *tel) | |||
There was a problem hiding this comment.
input parameter can be const
please check for a valid tel pointer. If tel is NULL then return false
There was a problem hiding this comment.
maybe better should return true if tel is NULL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function
telev_is_empty()to query if DTMF characters have been sent out completely.