Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aes/openssl: remove obsolete version check #572

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

alfredh
Copy link
Contributor

@alfredh alfredh commented Oct 9, 2022

No description provided.

@sreimers
Copy link
Member

sreimers commented Oct 10, 2022

At the moment we have OpenSSL v1.1.0 support listed, should we drop it? Fine by me, can you update README.md. So we can drop some more checks:

./src/md5/wrap.c:28:#if OPENSSL_VERSION_NUMBER >= 0x10100000L
./src/tls/openssl/tls.h:17:#if OPENSSL_VERSION_NUMBER >= 0x10100000L && \
./src/tls/openssl/tls.h:24:#if OPENSSL_VERSION_NUMBER >= 0x10100000L
./src/tls/openssl/tls.c:144:#if OPENSSL_VERSION_NUMBER >= 0x10100000L && \
./src/tls/openssl/tls.c:438:#if OPENSSL_VERSION_NUMBER >= 0x10100000L
./src/tls/openssl/tls.c:503:#if OPENSSL_VERSION_NUMBER >= 0x10100000L
./src/tls/openssl/tls.c:570:#if OPENSSL_VERSION_NUMBER >= 0x10100000L
./src/tls/openssl/tls.c:1277:#if OPENSSL_VERSION_NUMBER >= 0x10100000L && \
./src/tls/openssl/tls.c:1480:#if (OPENSSL_VERSION_NUMBER >= 0x10100000L)
./src/tls/openssl/tls.c:1504:#if (OPENSSL_VERSION_NUMBER >= 0x10100000L)
./src/tls/openssl/tls_tcp.c:333:#if OPENSSL_VERSION_NUMBER >= 0x10100000L && \

@alfredh
Copy link
Contributor Author

alfredh commented Oct 11, 2022

Sorry I did not mean to remove support for 1.1.0

I think we should support these versions:

  • OpenSSL 1.1.0
  • OpenSSL 1.1.1
  • OpenSSL 3.0.0

Over time we can consider to drop the oldest version, if it is a big maintenance burdon.

Can you please check again the VERSION check:

https://stackoverflow.com/questions/63942436/determining-openssl-version-with-ifdef

@sreimers sreimers merged commit 7d57d91 into main Oct 11, 2022
@sreimers sreimers deleted the aes_openssl_version branch October 11, 2022 06:33
@robert-scheck
Copy link
Contributor

According to https://www.openssl.org/policies/releasestrat.html "Versions 1.1.0, 1.0.1, 1.0.0 and 0.9.8 are no longer supported", thus support for at least OpenSSL 1.1.1 (for CentOS/RHEL/Rocky 7 and 8) would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants