sipreg fix contact handler expires evaluation
#581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The experies parameter in the contact handler from SIP server was not evaluated if the server (e.g. Asterisk) uses upper case form: ";transport=TLS".
SIP proxies/registrar might rewrite the port number in the Contact header. E.g. Asterisk with setting rewrite_contact. In such a case expires parameter from the SIP registrar should also be evaluated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits solve the problem that in some situations the
;expires=parameter in the Contact header in the response to the REGISTER is not evaluated.There are two more problems/questions which are related to this:
contact_handlerreturnsfalse. Then the expires is not evaluated, without any warning. Should there be any error handling?re,baresipupdate it's Contact handler for following SIP requests?