Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: get default source addr #66

Merged
merged 1 commit into from
Feb 18, 2021
Merged

net: get default source addr #66

merged 1 commit into from
Feb 18, 2021

Conversation

sreimers
Copy link
Member

@sreimers sreimers commented Jan 15, 2021 •
edited
Loading

Especially under windows the selection of the default ip/route is not very reliable. If the new approach fails, it fallbacks to the old mechanisms.

Todo:

  • Windows testing (with single adapter)
  • Windows testing (with multiple adapters)
  • macOS testing (single)
  • macOS testing (multiple)
  • Linux testing (single)
  • Linux testing (multiple)

@sreimers sreimers marked this pull request as ready for review January 30, 2021 16:38
@sreimers sreimers marked this pull request as draft January 30, 2021 16:51
@sreimers sreimers changed the title net: get default source addr from udp local test socket net: get default source addr Feb 18, 2021
@sreimers sreimers marked this pull request as ready for review February 18, 2021 20:46
@sreimers sreimers merged commit d7089d0 into master Feb 18, 2021
@sreimers sreimers deleted the default_source_addr branch February 18, 2021 20:54
@sreimers sreimers added the enhancement New feature or request label Apr 9, 2021
@sreimers sreimers added this to the v2.0.0 milestone Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Roadmap RE
Archived in project
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@sreimers